KEMBAR78
Check doc fully active during response.complete() by marcoscaceres · Pull Request #748 · w3c/payment-request · GitHub
Skip to content

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 5, 2018

closes #731

The following tasks have been completed:


Preview | Diff

@marcoscaceres marcoscaceres requested a review from domenic July 5, 2018 21:59
index.html Outdated
</li>
</ol>
</li>
<li>Otherwise, close down any remaining user interface. The <a>user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe all three of these steps should be under "otherwise"? Doesn't actually have normative impact, but seems cleaner.

@marcoscaceres
Copy link
Member Author

Tested as part of web-platform-tests/wpt#11101 which is still in review.

@marcoscaceres marcoscaceres merged commit a0ff44f into gh-pages Jul 16, 2018
@marcoscaceres marcoscaceres deleted the complete_doc_check branch July 16, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we need "doc is fully active" checks on response.complete()?

2 participants