KEMBAR78
Describe privacy inplications of changing payment method by marcoscaceres · Pull Request #849 · w3c/payment-request · GitHub
Skip to content

Describe privacy inplications of changing payment method #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2019
Merged

Describe privacy inplications of changing payment method #849

merged 4 commits into from
Mar 13, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 12, 2019 •
edited by pr-preview bot
Loading

Attempt to address feedback from @wseltzer as part of PING feedback.

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Has undergone security/privacy review

Optional, impact on Payment Handler spec?

Preview | Diff

rsolomakhin
rsolomakhin approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the standpoint of payment handlers. The PH API does not yet have the payment method change event defined, but I will keep this PR in mind when adding it.

ianbjacobs
ianbjacobs requested changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@ianbjacobs ianbjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marcos,

Minor editorial suggestions.

ianbjacobs and others added 2 commits March 13, 2019 13:07
@marcoscaceres marcoscaceres merged commit 76135b9 into gh-pages Mar 13, 2019
@marcoscaceres marcoscaceres deleted the paymentmethodchange_priv branch May 16, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsolomakhin rsolomakhin rsolomakhin approved these changes

@ianbjacobs ianbjacobs ianbjacobs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcoscaceres @rsolomakhin @ianbjacobs