Changes stemming from privacy review #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected bug by removing MUST language from the informative introduction. - Corrected bug by aligning the definition of requestBillingAddress (under 9. PaymentOptions dictionary) to look like the other definitions (and include "SHOULD"). - Enhanced 19.6 Exposing user information by explaining more both the reason for PaymentMethodChangeEvent and the privacy implications. Enhanced the explanation by allowing for other ways to minimize data sharing, including an emerging idea for providing an "exclude" array (or similar) as payee request data that could be used by the payment method definition to limit which response elements are returned.
marcoscaceres
approved these changes
Mar 26, 2019
adrianhopebailie
approved these changes
Mar 26, 2019
|
@ianbjacobs - these changes look good to me. I think this PR will help address some of the questions raised by PLH and Ralph. |
|
My first impression is that these changes to do not resolve the concern I raised in #842. I am happy to discuss this further after the IETF meeting. |
|
Got ok from W3C Director to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @plehegar, @swickr, @samuelweiler
for PaymentMethodChangeEvent and the privacy implications. Enhanced the
explanation by allowing for other ways to minimize data sharing, including
an emerging idea for providing an "exclude" array (or similar) as payee
request data that could be used by the payment method definition to
limit which response elements are returned.
Relates to
w3c/payment-method-basic-card#72
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
https://github.com/w3c/payment-request-info/wiki/PaymentMethodPractice
If we merge this pull request, I would like to update that documentation to mention privacy protection around the event.
Preview | Diff