Negative values allowed in cHRM
#528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisn
approved these changes
Jul 7, 2025
|
I think it would be good to add an informational note in the cHRM section along the lines of: "Previous versions of this specification used unsigned 4-byte integers for these values, but the change is backwards compatible because PNG restricts 4-byte unsigned integers to the range 0 - 2^31-1 (rather than 0 - 2^32-1)". |
It would be good, yes (sorry, only saw your comment after merging) |
|
So can I add another commit here even after merge or should I make a new PR to add the explanation? |
|
Adding a note is a good idea, I'd suggest here as logically it's part of this change. |
|
I tried but this PR doesn't pick up the change: chris@SuperNomad:/mnt/c/Users/chris/Documents/GitHub/png$ git checkout negative-cHRM
Switched to branch 'negative-cHRM'
Your branch is up to date with 'origin/negative-cHRM'.
chris@SuperNomad:/mnt/c/Users/chris/Documents/GitHub/png$ git pull --rebase
Already up to date.
chris@SuperNomad:/mnt/c/Users/chris/Documents/GitHub/png$ explorer.exe .
(I make the edit and commit it)
chris@SuperNomad:/mnt/c/Users/chris/Documents/GitHub/png$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 20 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 584 bytes | 22.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To github.com:w3c/png.git
64a79c2..63f00ee negative-cHRM -> negative-cHRM |
|
So here it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.