Selector [foo='bar' I] (uppercase I) is valid #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change expectation of [foo='bar' I] test case from invalid to valid. Fixes https://lists.w3.org/Archives/Public/www-style/2016Jan/0169.html r=@fsoder
|
Critic review: https://critic.hoppipolla.co.uk/r/6133 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Fwiw, I'm making a similar change to this file in https://bugzilla.mozilla.org/show_bug.cgi?id=888190 so we'll have to keep an eye on merge conflicts.... |
|
@bzbarsky OK, would you prefer to upstream your change instead? |
|
I'm fine either way; my change won't happen for a few more days at least because it needs review from someone who's on vacation. |
|
@bzbarsky FYI this is now reviewed (in critic) and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change expectation of [foo='bar' I] test case from invalid to valid.
Fixes https://lists.w3.org/Archives/Public/www-style/2016Jan/0169.html
r=@fsoder