[css-text] Test text-align: match-parent on the root element #30175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
frivoal,
kojiishi,
nox,
plinss and
r12a
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
zcorpan
force-pushed
the
bocoup/css-text-align-match-parent
branch
2 times, most recently
from
fb5229b to
eae5a5a
Compare
|
@zcorpan There's already a test for this: css/css-text/text-align/text-align-match-parent-root-rtl.html It was in mozilla vendor-imports then was moved to the main test suite. |
|
Wait, I guess not, this tests the computed style. |
nt1m
reviewed
Jun 1, 2022
nt1m
reviewed
Jun 1, 2022
zcorpan
force-pushed
the
bocoup/css-text-align-match-parent
branch
from
7694a91 to
94c54b0
Compare
|
@nt1m thanks, fixed. |
|
Maybe this could be named "text-align-match-parent-root-rtl-computed.html" to be consistent with the text-align-match-parent-root-rtl.html test. Regarding the test that was renamed to "match-parent-001.html", can things be consistent with the rest of the match-parent tests: https://wpt.fyi/results/css/css-text/text-align?label=master&label=experimental&aligned&q=text-align-match-parent- ? The other tests could be renamed. |
frivoal
reviewed
Dec 29, 2022
Co-authored-by: Florian Rivoal <git@florian.rivoal.net>
zcorpan
commented
Jan 3, 2023
nt1m
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, a used value of 'direction: rtl' on the root element is propagated to the ICB per https://drafts.csswg.org/css-writing-modes-3/#icb
Then, https://drafts.csswg.org/css-text/#valdef-text-align-match-parent says
The initial value of text-align is 'start', so I guess the inherited value for the root element has to be 'start'. Therefore, it looks at the 'direction' of the ICB, which is propagated from the root element, and is thus 'rtl'. Therefore text-align should compute to 'right'.