KEMBAR78
[SPC] Update tests for input parameter validation by stephenmcgruer · Pull Request #34739 · web-platform-tests/wpt · GitHub
Skip to content

[SPC] Update tests for input parameter validation #34739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2022
Merged

[SPC] Update tests for input parameter validation #34739

merged 2 commits into from
Jul 8, 2022

Conversation

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jul 7, 2022 •
edited
Loading

See w3c/secure-payment-confirmation#195

The following tests are new:

  • Empty ID within credentialIds field throws exception
  • Multiple IDs in credentialIds is valid
  • Empty instrument.displayName field throws exception
  • Empty instrument.icon field throws exception
  • Invalid instrument.icon URL throws exception
  • Invalid rpId field throws exception
  • Non-HTTPS payee origin throws exception

One timeout test was removed.

@stephenmcgruer stephenmcgruer force-pushed the smcgruer/wpt-tests-update branch from 073dd99 to 9538cad Compare July 7, 2022 19:21
@stephenmcgruer stephenmcgruer marked this pull request as ready for review July 7, 2022 19:21
@stephenmcgruer
Copy link
Contributor Author

Azure pipeline failures seem to be #34752

@stephenmcgruer stephenmcgruer merged commit 4d5244f into master Jul 8, 2022
@stephenmcgruer stephenmcgruer deleted the smcgruer/wpt-tests-update branch July 8, 2022 13:29
@stephenmcgruer stephenmcgruer restored the smcgruer/wpt-tests-update branch July 8, 2022 13:29
@stephenmcgruer stephenmcgruer deleted the smcgruer/wpt-tests-update branch July 8, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsolomakhin rsolomakhin rsolomakhin approved these changes

Assignees

@rsolomakhin rsolomakhin

Labels

secure-payment-confirmation wg-payments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenmcgruer @rsolomakhin @wpt-pr-bot