KEMBAR78
Core-AAM: add tests for sectionheader and sectionfooter by spectranaut · Pull Request #45916 · web-platform-tests/wpt · GitHub
Skip to content

Core-AAM: add tests for sectionheader and sectionfooter #45916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

Core-AAM: add tests for sectionheader and sectionfooter #45916

merged 2 commits into from
Aug 12, 2024

Conversation

@spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Apr 25, 2024 •
edited
Loading

Change in ARIA: w3c/aria#1931

@spectranaut spectranaut marked this pull request as ready for review April 26, 2024 16:31
@spectranaut spectranaut mentioned this pull request Apr 26, 2024
Merged
8 tasks
@spectranaut spectranaut requested a review from rahimabdi May 2, 2024 17:26
rahimabdi
rahimabdi approved these changes May 5, 2024
View reviewed changes
cookiecrook
cookiecrook reviewed May 7, 2024
View reviewed changes
cookiecrook
cookiecrook requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would result in new failures for Interop, so please keep the WebDriver role verifications out. Adding to a roles.tentative.html file is fine, as those don't affect the score.

Even if we agreed on the test additions, there's a process inside the current Interop project together sign off from implementors before making new changes that would affect the score mid-year.

@spectranaut spectranaut force-pushed the sectionheader-sectionfooter branch from f28d642 to 2aa23d5 Compare May 7, 2024 16:03
@spectranaut spectranaut changed the title ARIA: add tests for sectionheader and sectionfooter Core-AAM: add tests for sectionheader and sectionfooter May 7, 2024
@spectranaut
Copy link
Contributor Author

Ok @cookiecrook -- I moved sectionheader and sectionfooter to a tentative file: #46142

If we need sign off from implementers for WPT tests of new futures added to ARIA, we should note that in the ARIA process documents, I'll ping you for a review of that draft.

@spectranaut spectranaut requested a review from cookiecrook May 7, 2024 16:07
@cookiecrook
Copy link
Contributor

I moved sectionheader and sectionfooter to a tentative file: #46142

Thanks. FYI there is still an accidental white space diff remaining in roles.html.

@tranjocelyn
Copy link
Contributor

Is there a PR to update the header and footer (scoped to main/sectioning content) subtests in html-aam/roles-contextual.html and wai-aria/role/contextual-roles.html? 

I have the implementation for sectionheader and sectionfooter ready for Chrome, but it's currently failing those subtests. I'm holding off on merging the code because it would negatively impact our Interop score.

@spectranaut
Copy link
Contributor Author

Is there a PR to update the header and footer (scoped to main/sectioning content) subtests in html-aam/roles-contextual.html and wai-aria/role/contextual-roles.html?

I have the implementation for sectionheader and sectionfooter ready for Chrome, but it's currently failing those subtests. I'm holding off on merging the code because it would negatively impact our Interop score.

Hi Joceyln, if there is a missing test or failing test, maybe make an issue on ARIA with the details so we can update it? This PR just has manual tests to keep track of the API mappings.

@spectranaut spectranaut force-pushed the sectionheader-sectionfooter branch from 2aa23d5 to 7c624e6 Compare July 30, 2024 20:22
cookiecrook
cookiecrook reviewed Jul 31, 2024
View reviewed changes
cookiecrook
cookiecrook approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the updates from the spec PR

@rahimabdi rahimabdi self-requested a review August 11, 2024 21:40
rahimabdi
rahimabdi reviewed Aug 11, 2024
View reviewed changes
Copy link
Contributor

@rahimabdi rahimabdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookiecrook has kindly provided comments/suggested feedback.

@spectranaut @cookiecrook
Apply suggestions from code review
9d4060e 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@spectranaut
Copy link
Contributor Author

Thanks @cookiecrook ! Fixed.

@spectranaut spectranaut enabled auto-merge (squash) August 12, 2024 21:27
@spectranaut spectranaut merged commit df93215 into master Aug 12, 2024
@spectranaut spectranaut deleted the sectionheader-sectionfooter branch August 12, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahimabdi rahimabdi rahimabdi approved these changes

@cookiecrook cookiecrook cookiecrook approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

@joanmarie joanmarie Awaiting requested review from joanmarie

@michael-n-cooper michael-n-cooper Awaiting requested review from michael-n-cooper

Assignees

@cookiecrook cookiecrook

Labels

core-aam wai-aria wg-wai_pf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spectranaut @cookiecrook @tranjocelyn @rahimabdi @wpt-pr-bot @moz-wptsync-bot