Sync interfaces/ with @webref/idl 3.47.3 #46056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
actions/update-idl
branch
7 times, most recently
from
a40984d to
4e41c58
Compare
github-actions
bot
force-pushed
the
actions/update-idl
branch
4 times, most recently
from
dc29871 to
acdd629
Compare
|
@foolip just wondering if there's anything blocking merging this PR |
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
acdd629 to
5c0c29c
Compare
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
actions/update-idl
branch
4 times, most recently
from
85d2624 to
179b152
Compare
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
179b152 to
99dd1ed
Compare
|
@rakuco sure thing, anyone can review and merge these PRs, but I understand it's mysterious what should be checked. What I do is:
In this case there's a timeout, and I actually don't know what might cause that. Probably not the IDL changes however, so the first thing I'd try is closing and reopening the PR to rerun CI. If that fixes it I'll assume unrelated flakiness and merge. |
|
Thanks, @foolip, this is the information I'd been looking for! The webrtc timeout seems to be gone on Safari, so I guess we're good to go? |
|
@rakuco, yep, good to go! |
foolip
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automated pull request updates interfaces/*.idl from @webref/idl 3.47.3.
Before merging, please check that any tests that depend on the updated IDL files still work. In particular, check for gray boxes as the wpt.fyi check status, which usually means that some tests have regressed.
If additional changes are needed, please manually create another PR based on this one.
See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.