Use img referrerpolicy attribute when fetching images #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initiating a fetch as part of the "update the image data" algorithm for `img`, we should use the element's `referrerpolicy` attribute, if present, to set the referrer policy on the request. See whatwg#1531 and w3c/webappsec-referrer-policy#40.
|
@domenic how does this look to you? |
source
Outdated
| <p>⌛ Set <var>request</var>'s <span>same-origin data-URL flag</span>.</p> | ||
|
|
||
| <p>⌛ If the element has a <code data-x="attr-img-referrerpolicy">referrerpolicy</code> | ||
| attribute, set <var>request</var>'s <span>referrer policy</span> to the current state of the |
There was a problem hiding this comment.
I think the first part should be removed; the state of the attribute is defined even when the attribute is not present.
|
Also need to add this to the algorithm "The user agent may at any time run the following algorithm to update an img element's image in order to react to changes in the environment." Thank you! |
|
@zcorpan thanks! I removed the provision for an unset attribute and added the referrerpolicy to the other algorithm you mentioned. |
|
This is perfect, thank you! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initiating a fetch as part of the "update the image data" algorithm
for
img, we should use the element'sreferrerpolicyattribute, ifpresent, to set the referrer policy on the request.
See #1531 and
w3c/webappsec-referrer-policy#40.