Only preload resources with matching type/as attributes #7851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Apr 25, 2022
source
Outdated
|
|
||
| <ul class="brief"> | ||
| <li><p><var>destination</var> is <code data-x="">audio</code> or <code data-x="">video</code>, | ||
| and <var>mimeTypeRecord</var> is an <span>audio or video MIME type</span></p></li> |
There was a problem hiding this comment.
We allow using as=audio type=video/blah?? That's a bit surprising... is it tested?
There was a problem hiding this comment.
It's expected since audio elements can play video tracks and vice versa.
I wasn't able to test media preloading reliably yet though, due to range responses, regardless of type verification.
There was a problem hiding this comment.
I would feel more comfortable merging this if we had some confirmation (e.g. by codebase inspection or via @annevk testimony, if we can't manage WPTs) that this was the desired behavior.
There was a problem hiding this comment.
I inspected the Chromium and WebKit code bases and this is based on that inspection.
domenic
reviewed
Apr 26, 2022
domenic
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes w3c/preload#113
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/links.html ( diff )
/semantics.html ( diff )