[perf] Update Delete Task to use DeleteFilesAsync. #16929

dellis1972 · 2022-12-01T12:34:28Z

No description provided.

dellis1972 · 2022-12-05T16:08:28Z

tests/bindings-test/ProtocolTest.cs

 			public override int GetHashCode ()
 			{
-				return HashCode.Combine(Name, Value);
+				return HashCode.Combine (Name, Value);


@rolfbjarne the code formatter fixed files I didn't touch :(

Yea, this is a known issue. I've fixed it by merging main into your branch.

Ah ok. I did a rebase this morning, hopefully that won't reverse things 👍

github-actions · 2022-12-06T10:56:07Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2022-12-06T12:46:53Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1182.Monterey
Hash: 8589215129bc608c4dfc86acbb7ea9b231b500fb [PR build]

vs-mobiletools-engineering-service2 · 2022-12-06T12:49:40Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 8589215129bc608c4dfc86acbb7ea9b231b500fb [PR build]

vs-mobiletools-engineering-service2 · 2022-12-06T12:52:09Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 8589215129bc608c4dfc86acbb7ea9b231b500fb [PR build]

vs-mobiletools-engineering-service2 · 2022-12-06T16:17:33Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8589215129bc608c4dfc86acbb7ea9b231b500fb [PR build]

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

dellis1972 force-pushed the DeleteFilesAsync branch from 1347e87 to 59953ea Compare December 2, 2022 10:23

This comment has been minimized.

Sign in to view

dellis1972 force-pushed the DeleteFilesAsync branch from 59953ea to fb62e08 Compare December 5, 2022 10:51

This comment was marked as outdated.

Sign in to view

dellis1972 commented Dec 5, 2022

View reviewed changes

dellis1972 marked this pull request as ready for review December 5, 2022 16:08

dellis1972 requested review from emaf, mauroa and rolfbjarne as code owners December 5, 2022 16:08

rolfbjarne approved these changes Dec 6, 2022

View reviewed changes

rolfbjarne changed the title ~~Update Delete Task to use DeleteFilesAsync~~ [perf] Update Delete Task to use DeleteFilesAsync. Dec 6, 2022

rolfbjarne added the performance If an issue or pull request is related to performance label Dec 6, 2022

This comment has been minimized.

Sign in to view

Update Delete Task to use DeleteFilesAsync

83b68c6

Fix compile error

7e63a41

dellis1972 force-pushed the DeleteFilesAsync branch from f6fa00d to 7e63a41 Compare December 6, 2022 10:50

Auto-format source code

8589215

github-actions bot requested a review from dalexsoto as a code owner December 6, 2022 10:56

mauroa approved these changes Dec 6, 2022

View reviewed changes

emaf approved these changes Dec 6, 2022

View reviewed changes

Merge branch 'main' into DeleteFilesAsync

ee67985

rolfbjarne merged commit 669070c into dotnet:main Dec 7, 2022

[perf] Update Delete Task to use DeleteFilesAsync. #16929

[perf] Update Delete Task to use DeleteFilesAsync. #16929

Uh oh!

Conversation

dellis1972 commented Dec 1, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

dellis1972 Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

dellis1972 Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 6, 2022

⚠️ Your code has been reformatted. ⚠️

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 6, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 6, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 6, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 6, 2022

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants