-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
duplicatetype/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features
Description
I'm frequently copying and pasting links from the integrated terminal in VSCode that point to internal services and local machines. It would be absolutely killer for me if I could ctrl+click those links to open them in the browser.
The regexes for creating links seem to require a TLD, with the exception of localhost. Is there a reason y'all are specifically restricting things that way? Could we instead allow any string that satisfies the hostname standard?
As an added bonus, this fix would take care of #601 as well. Would be happy to work on this if it sounds reasonable.
Details
- Browser and browser version: VSCode
- OS version: Ubuntu 14.04
- xterm.js version: "Tyriar/xterm.js#vscode-release/1.12"
Steps to reproduce
- echo "http://myhostname/blah"
- hover over it
Metadata
Metadata
Assignees
Labels
duplicatetype/enhancementFeatures or improvements to existing featuresFeatures or improvements to existing features