KEMBAR78
DomRenderer draw selection inactive background correctly when unfocused by tisilent · Pull Request #4763 · xtermjs/xterm.js · GitHub
Skip to content

DomRenderer draw selection inactive background correctly when unfocused #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 9, 2023
Merged

DomRenderer draw selection inactive background correctly when unfocused #4763

merged 9 commits into from
Sep 9, 2023
+31 −3

Conversation

@tisilent
Copy link
Contributor

@tisilent tisilent commented Sep 8, 2023

fix #4750.

Tyriar
Tyriar approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works 👍

I reverted the demo parts as there's too many theme keys to do that (though we may add theme customization to the options tab at some point). I did set the default value for the inactive theme key to the default theme though.

@Tyriar Tyriar self-assigned this Sep 9, 2023
@Tyriar Tyriar added this to the 5.4.0 milestone Sep 9, 2023
@Tyriar Tyriar enabled auto-merge September 9, 2023 02:59
@Tyriar Tyriar disabled auto-merge September 9, 2023 02:59
@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2023

Added a regression test

@tisilent
Copy link
Contributor Author

tisilent commented Sep 9, 2023

I also try the playwright test.

@Tyriar Tyriar changed the title When DomRenderer blue,perform rendering. DomRenderer draw selection inactive background correctly when unfocused Sep 9, 2023
@Tyriar Tyriar enabled auto-merge September 9, 2023 13:22
@Tyriar Tyriar force-pushed the fix-selection-background-domrenderer branch from fa1356c to a101135 Compare September 9, 2023 13:28
@Tyriar Tyriar merged commit 3d440e2 into xtermjs:master Sep 9, 2023
@tisilent tisilent mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

DOM renderer: Selection background is drawn incorrectly when unfocused

2 participants

@tisilent @Tyriar