KEMBAR78
get voiceover to announce terminal output consistently by meganrogge · Pull Request #4789 · xtermjs/xterm.js · GitHub
Skip to content

Conversation

@meganrogge
Copy link
Member

@meganrogge meganrogge commented Sep 11, 2023

fix #3247

Works great in the demo. Testing in VS Code now

The "stutter" mentioned here is very minor. #3247 (comment), but looking into it.

voiceover.mov

@meganrogge meganrogge self-assigned this Sep 11, 2023
@meganrogge meganrogge added this to the 5.4.0 milestone Sep 11, 2023
@meganrogge meganrogge requested a review from Tyriar September 11, 2023 16:44
@meganrogge
Copy link
Member Author

Logging shows that we are doing the right thing here, so I believe the stuttering is a VoiceOver issue

Screenshot 2023-09-11 at 12 17 43 PM

@meganrogge
Copy link
Member Author

meganrogge commented Sep 11, 2023

works in VS Code, though sometimes reads duplicate information.
https://github.com/xtermjs/xterm.js/assets/29464607/745972b6-e446-480a-bd11-544c0df13a93

@meganrogge meganrogge merged commit f69fcb9 into xtermjs:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

screen reader mode rarely reads command output with VoiceOver

2 participants