KEMBAR78
Fix spacing issue when measuring before element is attached by Tyriar · Pull Request #4973 · xtermjs/xterm.js · GitHub
Skip to content

Fix spacing issue when measuring before element is attached #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix spacing issue when measuring before element is attached #4973

merged 1 commit into from
Feb 29, 2024

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 29, 2024 •
edited
Loading

@Tyriar Tyriar added this to the 5.4.0 milestone Feb 29, 2024
@Tyriar Tyriar self-assigned this Feb 29, 2024
@Tyriar Tyriar mentioned this pull request Feb 29, 2024
Closed
@Tyriar Tyriar enabled auto-merge February 29, 2024 15:38
@Tyriar Tyriar merged commit fb867a9 into xtermjs:master Feb 29, 2024
@jerch
Copy link
Member

jerch commented Feb 29, 2024

@Tyriar Oh wow, thats awkward - any idea why the letter measuring might return 0 sometimes?

@Tyriar Tyriar mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @jerch