KEMBAR78
Accommodate changes in lfilter by yoyolicoris · Pull Request #4 · yoyolicoris/torchaudio · GitHub
Skip to content

Conversation

yoyolicoris
Copy link
Owner

No description provided.

imaginary-person and others added 17 commits February 19, 2021 10:02
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Remove duplicate --bits command line parameter. It's producing a warning with sox.
Summary:
Pull Request resolved: pytorch/pytorch#51319

We were going out of our way to accommodate `IValue::to<Tensor>` returning a copy of the inner Tensor. `IValue::toTensor` is capable of returning a reference without copying, so if we use it directly, we can allow kernels that want to take `Tensor &` to do so!
As a bonus, we get reduced build times.
ghstack-source-id: 121378961

Reviewed By: bhosmer

Differential Revision: D26138549

fbshipit-source-id: b0f830527da360c542c815bef2f7e1692615b32a

Co-authored-by: Scott Wolchok <swolchok@fb.com>
* Fix fileobj I/O undeterministic behavior

Ever since the file-like object support was added in #1158, the test
was occasionally failing in CI. This PR fixes this.
Numpy is a dependency of pytorch so we should let it get resolved as it
install pytorch

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Some audio formats like `gsm` does not have valid frame numbers when opened. But `libsox` can properly handle these audios, so checking if `length > 0` is not necessary and too strict.
@yoyolicoris yoyolicoris merged commit f695635 into yoyolicoris:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants