notify_subscriptions_*: Fix use of leaked stream variable.

timabbott · timabbott · commit e9f39922a09d · 2016-02-03T19:25:17.000-08:00
While I believe this actually produced correct output since users are
always subscribed to streams within their realm, this code was
definitely wrong.

Discovered using the mypy type-checking tool.
diff --git a/zerver/lib/actions.py b/zerver/lib/actions.py
@@ -1135,7 +1135,7 @@ def notify_subscriptions_added(user_profile, sub_pairs, stream_emails, no_log=Fa
         log_event({'type': 'subscription_added',
                    'user': user_profile.email,
                    'names': [stream.name for sub, stream in sub_pairs],
-                   'domain': stream.realm.domain})
+                   'domain': user_profile.realm.domain})
 
     # Send a notification to the user who subscribed.
     payload = [dict(name=stream.name,
@@ -1305,7 +1305,7 @@ def notify_subscriptions_removed(user_profile, streams, no_log=False):
         log_event({'type': 'subscription_removed',
                    'user': user_profile.email,
                    'names': [stream.name for stream in streams],
-                   'domain': stream.realm.domain})
+                   'domain': user_profile.realm.domain})
 
     payload = [dict(name=stream.name, stream_id=stream.id) for stream in streams]
     event = dict(type="subscription", op="remove",
