lint: Replace pycodestyle and pyflakes with ruff #23431
Merged
+115
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/charliermarsh/ruff Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
andersk
added
the
integration review
|
Looks great, merged, thanks @andersk! |
|
Also this is just ridiculously fast. I think |
|
@charliermarsh FYI, we’re now using ruff in Zulip! Thanks for this really great tool. |
|
@andersk - Wow, amazing! Thank you for all your contributions too! Please feel free to hold a low bar for filing issues, requesting features, etc. |
|
@timabbott - I'm going to start on import sorting soon (astral-sh/ruff#465). It won't be as flexible as |
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff is an extremely fast Python linter written in Rust. It has near-parity with the pycodestyle and pyflakes rules not covered by Black, plus many helpful Flake8 plugins that we should have been using. It supports caching and autofixing. It’s very actively developed with multiple releases per day at this point. It has some limitations with parsing certain Python 3.9–only syntax features due to its LR(1) parser, which might be concerning if it weren’t so actively developed, but I’m confident that will be addressed in time.