KEMBAR78
Fix missing comma between items in _CPP_HEADERS by Hs293Go · Pull Request #300 · cpplint/cpplint · GitHub
Skip to content

Conversation

@Hs293Go
Copy link
Contributor

@Hs293Go Hs293Go commented Dec 2, 2024

This PR restores a comma between 'latch' and 'numbers'. Currently, the missing comma causes them to be implicitly concatenated into 'latchnumbers', so cpplint won't recognize either header in C++20 code and report a bogus build/include_order error.

Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we really should've noticed this before the release.

@aaronliu0130 aaronliu0130 merged commit 14445f3 into cpplint:develop Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants