KEMBAR78
GitHub Actions: pipx run pre-commit run --all-files by cclauss · Pull Request #324 · cpplint/cpplint · GitHub
Skip to content

GitHub Actions: pipx run pre-commit run --all-files #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

GitHub Actions: pipx run pre-commit run --all-files #324

merged 2 commits into from
Mar 6, 2025

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Mar 6, 2025

No description provided.

@cclauss cclauss requested review from aaronliu0130 and jayvdb March 6, 2025 22:41
@cclauss cclauss changed the title GitHub Actions: pipx run pre-commit --all-files GitHub Actions: pipx run pre-commit run --all-files Mar 6, 2025
aaronliu0130
aaronliu0130 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if/when the checks complete. BTW I wonder if we should add pre-commit to dev-requirements?

@cclauss cclauss mentioned this pull request Mar 6, 2025
Merged
@cclauss
Copy link
Member Author

cclauss commented Mar 6, 2025

Let's not add pre-commit to dev requirements. It is optional. If contributors do not install it GitHub Actions will still catch the problems.

@cclauss cclauss merged commit fe8ce9a into develop Mar 6, 2025
7 checks passed
@cclauss cclauss deleted the pipx-run-pre-commit---all-files branch March 6, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronliu0130 aaronliu0130 aaronliu0130 approved these changes

@jayvdb jayvdb Awaiting requested review from jayvdb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @aaronliu0130