-
Notifications
You must be signed in to change notification settings - Fork 21
Comparing changes
Open a pull request
base repository: cyphar/filepath-securejoin
base: v0.3.6
head repository: cyphar/filepath-securejoin
compare: v0.4.0
- 9 commits
- 7 files changed
- 1 contributor
Commits on Dec 17, 2024
-
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 682d3ad - Browse repository at this point
Copy the full SHA 682d3adView commit details -
merge #38 into cyphar/filepath-securejoin:main
Aleksa Sarai (2): VERSION: back to development VERSION: release v0.3.6 LGTMs: cyphar
Configuration menu - View commit details
-
Copy full SHA for b498783 - Browse repository at this point
Copy the full SHA b498783View commit details
Commits on Dec 18, 2024
-
gha: always check for latest Go release
The default setting could result in us testing against old patch releases of Go versions, so force actions/setup-go to check if the cached version is the latest. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 1be4136 - Browse repository at this point
Copy the full SHA 1be4136View commit details
Commits on Jan 9, 2025
-
join: return an error if root is unclean path
If a user provides an unclean root path, we will implicitly clean it at the end of SecureJoin (which may result in a path that doesn't exist or has "escaped" the root). Such usage is fundamentally unsafe so we should just return an error. Reported-by: Erik Sjölund <erik.sjolund@gmail.com> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for bc750ad - Browse repository at this point
Copy the full SHA bc750adView commit details
Commits on Jan 10, 2025
-
merge #43 into cyphar/filepath-securejoin:main
Aleksa Sarai (1): join: return an error if root is unclean path LGTMs: cyphar
Configuration menu - View commit details
-
Copy full SHA for f3a512c - Browse repository at this point
Copy the full SHA f3a512cView commit details
Commits on Jan 12, 2025
-
mkdirall: switch to os.FileMode argument
This is mostly a cosmetic change for most users, but libpathrs uses os.FileMode as well and most Go users are more used to using os.FileMode. The only thing that users need to watch out for is that they need to switch from unix.S_ISVTX to os.ModeSticky if they are using that bit (since os.FileMode and unix.S_* bits have a different layout). This will also help with building on 32-bit architectures without switching the argument type to uint32 explicitly. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 0c2fbe6 - Browse repository at this point
Copy the full SHA 0c2fbe6View commit details -
gha: add GOARCH=386 build check
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for ea4e5b6 - Browse repository at this point
Copy the full SHA ea4e5b6View commit details
Commits on Jan 13, 2025
-
merge #44 into cyphar/filepath-securejoin:main
Aleksa Sarai (2): gha: add GOARCH=386 build check mkdirall: switch to os.FileMode argument LGTMs: cyphar kolyshkin
Configuration menu - View commit details
-
Copy full SHA for e410d4a - Browse repository at this point
Copy the full SHA e410d4aView commit details -
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for 9a17e6b - Browse repository at this point
Copy the full SHA 9a17e6bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.3.6...v0.4.0