Allow Partial<Config> for createStatusReportBase
#3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the createStatusReportBase function to accept Partial<Config> instead of Config, enabling more flexible usage when only partial configuration data is available. The changes improve telemetry by allowing the start-proxy action to report language information even when a full configuration isn't available.
- Updates
createStatusReportBasefunction signature to acceptPartial<Config> | undefined - Adds null-safe access operators for config properties to handle partial configurations
- Modifies start-proxy action to populate language information in telemetry reports
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/status-report.ts | Updates function signature and adds null-safe property access |
| src/status-report.test.ts | Adds test coverage for empty and partial configuration scenarios |
| src/start-proxy.ts | Refactors getCredentials to accept KnownLanguage directly |
| src/start-proxy.test.ts | Updates test calls to pass KnownLanguage enum values |
| src/start-proxy-action.ts | Implements language parsing and telemetry reporting with partial config |
| lib/*.js | Generated JavaScript files reflecting the TypeScript changes |
mbg
force-pushed
the
mbg/telemetry/partial-config
branch
from
25db0e9 to
bdd2cdf
Compare
henrymercer
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type of
createStatusReportBaseto allowPartial<Config> | undefinedrather thanConfig | undefined. The unit tests forcreateStatusReportBaseare updated accordingly. I then made use of this to populate thelanguagesfield in thestart-proxytelemetry.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist