Add support for the WithMetricAttributesFn option for otelhttp middlewares
#6542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cally setting per-request metric attributes
|
Could you add tests? |
|
@dmathieu I have added some tests. |
dmathieu
changed the title
WithMetricAttributesFn option for otelhttp middlewares
dmathieu
approved these changes
Jan 6, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dashpole
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6542 +/- ##
=====================================
Coverage 68.5% 68.5%
=====================================
Files 200 200
Lines 16772 16781 +9
=====================================
+ Hits 11491 11500 +9
Misses 4935 4935
Partials 346 346
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add metricAttributesFn to http server handler in otelhttp, for dynamically setting per-request metric attributes