KEMBAR78
Duplicate client metrics with semconv v1.26 in otelhttp by dmathieu · Pull Request #6607 · open-telemetry/opentelemetry-go-contrib · GitHub
Skip to content

Duplicate client metrics with semconv v1.26 in otelhttp #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

Duplicate client metrics with semconv v1.26 in otelhttp #6607

merged 2 commits into from
Jan 14, 2025

Conversation

dmathieu
Copy link
Member

Closes #6261

@dmathieu dmathieu force-pushed the otelhttp-client-metrics branch from 6f80b1f to 99ef740 Compare January 13, 2025 12:13
@dmathieu dmathieu force-pushed the otelhttp-client-metrics branch from 99ef740 to c19c864 Compare January 13, 2025 12:16
@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.6%. Comparing base (9640704) to head (c19c864).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ion/net/http/otelhttp/internal/semconv/httpconv.go 87.3% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6607     +/-   ##
=======================================
+ Coverage   68.5%   68.6%   +0.1%     
=======================================
  Files        200     200             
  Lines      16781   16872     +91     
=======================================
+ Hits       11500   11585     +85     
- Misses      4935    4939      +4     
- Partials     346     348      +2
Files with missing lines Coverage Δ
...entation/net/http/otelhttp/internal/semconv/env.go 93.3% <100.0%> (+1.1%) ⬆️
instrumentation/net/http/otelhttp/transport.go 94.8% <100.0%> (ø)
...ion/net/http/otelhttp/internal/semconv/httpconv.go 87.0% <87.3%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review January 13, 2025 12:25
@dmathieu dmathieu requested a review from a team as a code owner January 13, 2025 12:25
@dmathieu dmathieu merged commit d5febab into open-telemetry:main Jan 14, 2025
26 checks passed
@dmathieu dmathieu deleted the otelhttp-client-metrics branch January 14, 2025 11:54
@MrAlias MrAlias added this to the v1.34.0 milestone Jan 17, 2025
@MrAlias MrAlias mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.34.0

Development

Successfully merging this pull request may close these issues.

Generate New Client Metrics in otelhttp

3 participants

@dmathieu @dashpole @MrAlias