Sdk builders extended with addProcessorFirst methods #7243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7243 +/- ##
============================================
+ Coverage 89.60% 89.62% +0.01%
- Complexity 6859 6862 +3
============================================
Files 780 780
Lines 20728 20735 +7
Branches 2018 2018
============================================
+ Hits 18574 18584 +10
+ Misses 1514 1512 -2
+ Partials 640 639 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gavarava
approved these changes
Apr 4, 2025
jack-berg
reviewed
Apr 10, 2025
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/LogRecordProcessor.java
Outdated
Show resolved
Hide resolved
onurkybsi
changed the title
jack-berg
approved these changes
Apr 17, 2025
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLoggerProviderBuilder.java
Show resolved
Hide resolved
| * @param processor the log processor | ||
| * @return this | ||
| */ | ||
| public SdkLoggerProviderBuilder addLogRecordProcessorFirst(LogRecordProcessor processor) { |
There was a problem hiding this comment.
This name follows the naming convention of Deque#addFirst, albeit "LogRecordProcessor" inserted between "add" and "First".
While it initially seems like a verbose name, I think its probably the best we can do to balance consistency with the existing "addLogRecordProcessor" and the precedent in java with Deque#addFirst.
onurkybsi
changed the title
trask
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue #6599.