KEMBAR78
Add support for mise.toml by hobbypunk90 · Pull Request #700 · ruby/setup-ruby · GitHub
Skip to content

Conversation

@hobbypunk90
Copy link
Contributor

No description provided.

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks good, just one small thing to address

const rubyLine = toolVersions.split(/\r?\n/).filter(e => /^ruby\s/.test(e))[0]
rubyVersion = rubyLine.match(/^ruby\s+(.+)$/)[1]
console.log(`Using ${rubyVersion} as input from file .tool-versions`)
} else if (rubyVersion === 'mise.toml') { // Read from mise.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mise.jdx.dev/configuration.html has 6 possible locations 😅
Hopefully mise.toml is the most common one, I don't really want to logic to search all those.
So yeah, let's look for just mise.toml for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, you are right 😅 especially the conf.d would be crap 😁

@eregon eregon merged commit ef45abe into ruby:master Feb 5, 2025
221 of 223 checks passed
@hobbypunk90 hobbypunk90 deleted the patch-1 branch February 5, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants