KEMBAR78
deps: upgrade gax to 1.53.0 by kolea2 · Pull Request #145 · googleapis/java-bigtable · GitHub
Skip to content

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jan 9, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #145 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
- Coverage     81.72%   81.69%   -0.04%     
  Complexity      952      952              
============================================
  Files            97       97              
  Lines          5927     5927              
  Branches        327      327              
============================================
- Hits           4844     4842       -2     
- Misses          905      907       +2     
  Partials        178      178
Impacted Files Coverage Δ Complexity Δ
.../stub/mutaterows/MutateRowsBatchingDescriptor.java 100% <100%> (ø) 11 <2> (ø) ⬇️
...om/google/cloud/bigtable/emulator/v2/Emulator.java 58.26% <0%> (-1.74%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea6704...65a15e2. Read the comment docs.

@kolea2 kolea2 requested a review from igorbernstein2 January 9, 2020 21:08
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with 2 nits

@kolea2 kolea2 merged commit c3fc40d into googleapis:master Jan 9, 2020
@kolea2 kolea2 deleted the gax-update-1.53 branch January 9, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants