KEMBAR78
fix: bigtable v2 retry config settings to disable streaming RPC retries by yoshi-automation · Pull Request #315 · googleapis/java-bigtable · GitHub
Skip to content

fix: bigtable v2 retry config settings to disable streaming RPC retries #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

fix: bigtable v2 retry config settings to disable streaming RPC retries #315

merged 1 commit into from
May 27, 2020

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/59cb7a6b-6cea-48ee-8325-d8f22ca64b00/targets

PiperOrigin-RevId: 312558019
Source-Link: googleapis/googleapis@a175708

@yoshi-automation
fix: bigtable v2 retry config settings to disable streaming RPC retries
5326a6d 
PiperOrigin-RevId: 312558019

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 20 14:40:11 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a175708acd7a367ab3ed120fa562331e1761d825
Source-Link: googleapis/googleapis@a175708
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #315 into master will increase coverage by 21.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #315       +/-   ##
=============================================
+ Coverage     59.67%   80.69%   +21.01%     
- Complexity       19     1049     +1030     
=============================================
  Files             2       99       +97     
  Lines           124     6541     +6417     
  Branches         18      344      +326     
=============================================
+ Hits             74     5278     +5204     
- Misses           33     1082     +1049     
- Partials         17      181      +164
Impacted Files Coverage Δ Complexity Δ
...ud/bigtable/data/v2/stub/BigtableStubSettings.java 74.52% <100.00%> (ø) 7.00 <0.00> (?)
...min/v2/stub/BigtableInstanceAdminStubSettings.java 96.05% <0.00%> (ø) 33.00% <0.00%> (?%)
...ogle/cloud/bigtable/data/v2/internal/NameUtil.java 88.88% <0.00%> (ø) 5.00% <0.00%> (?%)
...ud/bigtable/data/v2/BigtableDataClientFactory.java 95.55% <0.00%> (ø) 9.00% <0.00%> (?%)
...table/admin/v2/models/CreateAppProfileRequest.java 91.66% <0.00%> (ø) 7.00% <0.00%> (?%)
...a/v2/stub/readrows/ReadRowsResumptionStrategy.java 95.45% <0.00%> (ø) 11.00% <0.00%> (?%)
.../com/google/cloud/bigtable/data/v2/models/Row.java 90.74% <0.00%> (ø) 18.00% <0.00%> (?%)
...able/data/v2/stub/GrpcBigtableCallableFactory.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...le/admin/v2/BaseBigtableInstanceAdminSettings.java 9.21% <0.00%> (ø) 2.00% <0.00%> (?%)
.../admin/v2/stub/EnhancedBigtableTableAdminStub.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17e39f...5326a6d. Read the comment docs.

@kolea2 kolea2 merged commit a7e43f0 into master May 27, 2020
@kolea2 kolea2 deleted the autosynth-googleapis branch May 27, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @kolea2 @googlebot