fix: add cause to transaction errors on transaction commit #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
============================================
- Coverage 71.97% 71.56% -0.41%
+ Complexity 997 968 -29
============================================
Files 62 62
Lines 5323 5202 -121
Branches 599 579 -20
============================================
- Hits 3831 3723 -108
+ Misses 1304 1299 -5
+ Partials 188 180 -8 Continue to review full report at Codecov.
|
BenWhitehead
approved these changes
Feb 14, 2020
|
@rockwotj Can you run |
BenWhitehead
requested changes
Feb 14, 2020
BenWhitehead
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
FYI: We will shortly be addressing the transaction retry behavior across all of our SDKs. |
|
@rockwotj Can you update the PR title to follow conventionalcommits.org? It this case it would be: "fix: ddd cause to transaction errors on transaction commit" |
schmidt-sebastian
approved these changes
Feb 18, 2020
BenWhitehead
changed the title
BenWhitehead
approved these changes
Feb 18, 2020
|
Thanks for the improvement @rockwotj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if a transaction fails due to a precondition failure (which are retried, which is another bug) for example trying to update a document that doesn't exist you get a bad error message of "too many retries". Ideally retry is smarter, but this is a easy change that propagates the underlying error up to the ApiFuture result.
/cc @schmidt-sebastian @BenWhitehead