KEMBAR78
feat: examples of creating a signed url for a blob with generation by dmitry-fa · Pull Request #140 · googleapis/java-storage · GitHub
Skip to content

feat: examples of creating a signed url for a blob with generation #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

feat: examples of creating a signed url for a blob with generation #140

merged 2 commits into from
Feb 26, 2020

Conversation

dmitry-fa
Copy link
Contributor

Fixes #37

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020 •
edited
Loading

Codecov Report

Merging #140 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #140     +/-   ##
===========================================
- Coverage     63.77%   63.58%   -0.2%     
+ Complexity      540      539      -1     
===========================================
  Files            30       30             
  Lines          4745     4731     -14     
  Branches        456      426     -30     
===========================================
- Hits           3026     3008     -18     
- Misses         1564     1565      +1     
- Partials        155      158      +3
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java 80.78% <ø> (ø) 0 <0> (ø) ⬇️
...e/src/main/java/com/google/cloud/storage/Blob.java 82.24% <ø> (-0.11%) 29 <0> (-1)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...gle/cloud/storage/testing/RemoteStorageHelper.java 61.98% <0%> (-3.06%) 9% <0%> (ø)
...main/java/com/google/cloud/storage/BucketInfo.java 80.85% <0%> (-0.2%) 84% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 78.67% <0%> (-0.12%) 120% <0%> (ø)
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.64% <0%> (ø) 1% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da3e8d...35562a8. Read the comment docs.

@chingor13 chingor13 removed their request for review February 20, 2020 17:56
elharo
elharo reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elharo elharo merged commit 420212a into googleapis:master Feb 26, 2020
@dmitry-fa dmitry-fa deleted the signurl_generation2 branch June 26, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankyn frankyn Awaiting requested review from frankyn

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cloud Storage: Signed URL determine generation from BlobInfo

3 participants

@dmitry-fa @elharo @googlebot