-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added the space between the Deadline and Grading scale placeholder part #5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
warning: parser/current is loading parser/ruby26, which recognizes
warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.6. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 1 error(s) were found in ERB files Linting 1 files with 12 linters...expected attribute value after '=' (at >)
In file: app/views/assignments/_form.html.erb:22
WalkthroughThe pull request updates the assignment form layout by adding a margin-top class to the grade field element. Additionally, the database schema is refined by updating the precision configuration of the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 RuboCop (1.73)db/schema.rb.rubocop.yml: RSpec/FilePath has the wrong namespace - replace it with Rails/FilePath 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 16867 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 6048139 and detected 0 issues on this pull request. View more on Code Climate. |
@ThatDeparted2061 please help me how to resolve the failure of percy test did I need to make a new pr ? |
@Avichal296 why are you updating schema.rb ? this is a UI change and don't modify package-lock.json and yarn.lock. |
@senbo1 I will update that just wait for some time please! |
Fixes #5541
Describe the changes you have made in this PR -
Added the space between the Deadline and the grading scale placeholder section under the Assignment part
Screenshots of the UI changes (If any) -
Checklist before requesting a review
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit
Style
Chores