-
Notifications
You must be signed in to change notification settings - Fork 70
Add support for wrapping ui elements in a subflow #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Marked ready for review,. not certain where i can add tests or docs TBH. Will let the review dictate that |
There's a lot here, and it's quite transformational in terms of some of the helper/utilise functions being put in, but have done my best to at least offer a first sweep of opinions/thoughts. |
Going to re-review this today. I'm thinking a docs section inside the "User Guides" section would work well. I'm happy to write that, but don't have a hands on local working example for me to run with - I assume there is a branch I can checkout for NR core? Assuming it's https://github.com/Steve-Mcl/node-red/tree/config-in-subflow? For the tests, I can add more detail to the "Testing" docs I have on Dashboard with some tricks and tips I've learned, and it'll be nice to see someone else give those a go to sanity check my workflow. As E2E tests go - they're actually quite "fun" |
Oh @Steve-Mcl's it's wonderful Subflow Config & Flow in Editor:![]() ![]() Subflow Instances in Editor:![]() Rendered Instances in Dashboard:![]() |
Okay, one issue and I'm not sure how to resolve it. Setting widget size after it's been moved into a subflow. Because there is no group assigned to the widget, the sizing widget doesn't allow for interaction. |
Doesn't show all of it, but quick glimpse at the docs I've added: Screen.Recording.2024-03-08.at.16.13.25.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Steve-Mcl only two outstanding items:
Okay, one issue and I'm not sure how to resolve it. Setting widget size after it's been moved into a subflow. Because there is no group assigned to the widget, the sizing widget doesn't allow for interaction.
and E2E tests, where I've added more docs in with #657
# Conflicts: # nodes/config/ui_base.html
Happy to merge this without E2e's as currently, we test against Node-RED 3.1.x and should continue to do so for now. The existing E2E test portfolio will cover that this hasn't introduced any regressions, and once we officially move to |
Will this work with current node red or will it require V4? |
|
OK, thanks. We just have to be patient then :) |
Description
Adds support for using UI nodes in a subflow.
Depends on node-red/node-red#4587
Configs.in.subflows.-.dashboard.demo.mp4
Updated to use the subflow icon and provide a hint to the subflow template used in the tooltip:

TODO
Related Issue(s)
#270
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label