KEMBAR78
Remove temporary audit exception for lsr by samford · Pull Request #20615 · Homebrew/brew · GitHub
Skip to content

Remove temporary audit exception for lsr #20615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Remove temporary audit exception for lsr #20615

merged 1 commit into from
Sep 2, 2025

Conversation

samford
Copy link
Member

@samford samford commented Sep 1, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This removes the temporary audit_download_strategy exception for the lsr formula. This was necessary to be able to merge support for tangled.sh Git URLs (#20599), as it made the using: :git argument in the lsr formula redundant and caused the "formula audit" check to fail in brew CI.

I've set this as a draft until the aforementioned DownloadStrategy change is available in a brew release.

@samford
Remove temporary audit exception for lsr
3eb57bc 
This removes the temporary `audit_download_strategy` exception for
the `lsr` formula. This was necessary to be able to merge support for
tangled.sh Git URLs, as it made the `using: :git` argument in the
`lsr` formula redundant and caused the "formula audit" check to fail
in brew CI.
@samford samford marked this pull request as ready for review September 2, 2025 14:21
@samford
Copy link
Member Author

samford commented Sep 2, 2025

The DownloadStrategyDetector change is in the 4.6.8 brew release and we've removed the redundant using: :git argument from the lsr formula (Homebrew/homebrew-core#235750), so the formula audit check now passes. We're good to remove the lsr audit exception, so I'm going to go ahead and merge this now.

@samford samford added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 75350b4 Sep 2, 2025
55 of 56 checks passed
@samford samford deleted the remove-lsr-special-case branch September 2, 2025 14:41
@p-linnane
Copy link
Member

Thanks for all the work on this @samford!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samford @p-linnane @MikeMcQuaid