KEMBAR78
system_command: add missing `must_succeed` by bevanjkay · Pull Request #20654 · Homebrew/brew · GitHub
Skip to content

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Sep 9, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #20613 to add a missing must_succeed parameter.
Discovered in https://github.com/Homebrew/homebrew-cask/actions/runs/17564639258/job/49888905675?pr=227110#step:16:18

Resolves Homebrew/homebrew-cask#227138

@Bo98 Bo98 added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 80f9e67 Sep 9, 2025
36 checks passed
@Bo98 Bo98 deleted the system_command_parameter branch September 9, 2025 05:26
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

errors install gcloud-cli on brew 4.6.10

3 participants