KEMBAR78
Migrate Homebrew/command-not-found to Homebrew/brew by Rylan12 · Pull Request #20730 · Homebrew/brew · GitHub
Skip to content

Conversation

@Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Sep 19, 2025

Migrate Homebrew/command-not-found and its commands to this repository, allowing for Homebrew/homebrew-command-not-found to be deprecated.

I copied all of the files directly in the first commit, and then updated each command one at a time in the subsequent commits to make reviewing changes easier (hopefully).

I added an integration test for brew which-formula, but no intensive testing for the other commands, since brew command-not-found-init simply prints instructions, and brew which-update should hopefully end up deprecated later on.

I migrated the previous Homebrew/homebrew-command-not-found README.md to a page in the documentation, and made some minor modifications since it had been a while since it was touched.

Finally, I migrated the scheduled database update job to this repo.


The handler scripts now live under HOMEBREW_LIBRARY/command-not-found

This raises an issue where users who already have the shell integration set up will have it pointing to the old location.
How should we address this?

@MikeMcQuaid
Copy link
Member

This raises an issue where users who already have the shell integration set up will have it pointing to the old location.
How should we address this?

Perhaps something in the existing tap that points to here but prints a warning?

Otherwise: :shipit:!

@Rylan12 Rylan12 force-pushed the migrate-command-not-found branch from 868dd5b to 4ded5a9 Compare September 19, 2025 19:16
@Rylan12
Copy link
Member Author

Rylan12 commented Sep 19, 2025

I've added license headers to the migrated files indicating that they are under the MIT license. I'll let @Homebrew/plc determine whether relicensing is necessary and will defer to them for any tasks needed on that front moving forward.

All of the test and rbi files were created by me while making this, and can be licensed under Homebrew's license.

The only file that is actively relicensed is the scheduled database generation file. I was the original author and all updates made by other folks since the file's creation have been minor fixes, and I am allowing it to be relicensed under Homebrew's license.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge when you're happy!

@Rylan12 Rylan12 enabled auto-merge September 19, 2025 19:35
@Rylan12 Rylan12 added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit 6700ab3 Sep 19, 2025
38 checks passed
@Rylan12 Rylan12 deleted the migrate-command-not-found branch September 19, 2025 20:04
romkatv pushed a commit to romkatv/zsh4humans that referenced this pull request Sep 21, 2025
bfontaine added a commit to bfontaine/Dotfiles that referenced this pull request Sep 23, 2025
kang8 added a commit to kang8/.dotfiles that referenced this pull request Sep 24, 2025
The homebrew/command-not-found tap has been integrated into Homebrew core
as of Homebrew/brew#20730, so it's no longer
necessary to explicitly tap it.
oirehT pushed a commit to oirehT/zsh4humans that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants