-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Migrate Homebrew/command-not-found to Homebrew/brew #20730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps something in the existing tap that points to here but prints a warning? Otherwise: |
868dd5b to
4ded5a9
Compare
|
I've added license headers to the migrated files indicating that they are under the All of the test and The only file that is actively relicensed is the scheduled database generation file. I was the original author and all updates made by other folks since the file's creation have been minor fixes, and I am allowing it to be relicensed under Homebrew's license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge when you're happy!
The homebrew/command-not-found tap has been integrated into Homebrew core as of Homebrew/brew#20730, so it's no longer necessary to explicitly tap it.
Migrate Homebrew/command-not-found and its commands to this repository, allowing for Homebrew/homebrew-command-not-found to be deprecated.
I copied all of the files directly in the first commit, and then updated each command one at a time in the subsequent commits to make reviewing changes easier (hopefully).
I added an integration test for
brew which-formula, but no intensive testing for the other commands, sincebrew command-not-found-initsimply prints instructions, andbrew which-updateshould hopefully end up deprecated later on.I migrated the previous Homebrew/homebrew-command-not-found
README.mdto a page in the documentation, and made some minor modifications since it had been a while since it was touched.Finally, I migrated the scheduled database update job to this repo.
The handler scripts now live under
HOMEBREW_LIBRARY/command-not-foundThis raises an issue where users who already have the shell integration set up will have it pointing to the old location.
How should we address this?