KEMBAR78
Enable raise_on_warning in specs by dduugg · Pull Request #20763 · Homebrew/brew · GitHub
Skip to content

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 25, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves:

WARNING: Shared example group 'reinstall_pkgconf_if_needed' has been previously defined at:
  /opt/homebrew/Library/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed_spec.rb:7
...and you are now defining it at:
  /opt/homebrew/Library/Homebrew/test/cmd/shared_examples/reinstall_pkgconf_if_needed_spec.rb:7
The new definition will overwrite the original one.

and other problematic use of rspec

@dduugg dduugg marked this pull request as ready for review September 25, 2025 20:31
@dduugg dduugg enabled auto-merge September 25, 2025 20:31
@dduugg dduugg added this pull request to the merge queue Sep 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2025
@dduugg dduugg added this pull request to the merge queue Sep 25, 2025
Merged via the queue into main with commit 24fea90 Sep 25, 2025
38 checks passed
@dduugg dduugg deleted the dug/raise-warnings branch September 25, 2025 21:41
@MikeMcQuaid
Copy link
Member

Awesome work, thanks for this @dduugg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants