KEMBAR78
xcode_requirement: fix unversioned requirement by cho-m · Pull Request #20781 · Homebrew/brew · GitHub
Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 30, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@version = nil is used to handle depends_on :xcode or depends_on xcode: :build.

Converting this to empty string ("") causes

Error: Version must not be empty
Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
/opt/homebrew/Library/Homebrew/version.rb:499:in 'Version#initialize'
/opt/homebrew/Library/Homebrew/requirements/xcode_requirement.rb:40:in 'Class#new'
/opt/homebrew/Library/Homebrew/requirements/xcode_requirement.rb:40:in 'XcodeRequirement#message'

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with or without suggestion!

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@cho-m cho-m force-pushed the xcode_requirement-fix branch from fa171b4 to bd84b58 Compare October 1, 2025 00:25
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 1, 2025
@MikeMcQuaid
Copy link
Member

Thanks again @cho-m!

github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2025
xcode_requirement: fix unversioned requirement
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 0c011f6 Oct 1, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the xcode_requirement-fix branch October 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants