workflows/docker: add Docker Hub push fallback #20838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Linnane <patrick@linnane.io>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a fallback mechanism for Docker Hub push operations when the primary docker buildx imagetools create command fails. Instead of exiting with an error after 3 attempts, the workflow now falls back to manually pulling, tagging, and pushing images to Docker Hub.
- Replaces hard failure after 3 attempts with a manual push fallback
- Implements a loop to pull source images and tag them with target tags
- Uses standard
docker pushcommands as an alternative tobuildx imagetools
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MikeMcQuaid
approved these changes
Oct 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
workflows/docker: add Docker Hub push fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?We often get 400 errors even with retries when using
docker buildx imagetoolsto push to Docker Hub. Let's try to fall back to a manual push in case that happens.