KEMBAR78
cask/audit: recursively audit app bundle min os by bevanjkay · Pull Request #20865 · Homebrew/brew · GitHub
Skip to content

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Applications on macOS can sometimes have other nested applications, such as helper tools and renderer applications.
There are instances where the minimum OS version required is different in the helper tool to the main application.
We are currently only checking the primary application, but in cases where the nested applications require a newer version than the primary bundle, the application can only be run on the macOS version required by the nested application.

Unblocks: Homebrew/homebrew-cask#231939

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit e7ec097 Oct 13, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the recursively-audit-min-os branch October 13, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants