KEMBAR78
uv: set JEMALLOC_SYS_WITH_LG_PAGE for ARM64 Linux builds by woodruffw · Pull Request #234353 · Homebrew/homebrew-core · GitHub
Skip to content

uv: set JEMALLOC_SYS_WITH_LG_PAGE for ARM64 Linux builds #234353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

uv: set JEMALLOC_SYS_WITH_LG_PAGE for ARM64 Linux builds #234353

merged 2 commits into from
Aug 21, 2025

Conversation

@woodruffw
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This mirrors what uv's CI does, here: https://github.com/astral-sh/uv/blob/9c9efc89578bc9fd96502a0d084a77aa718b2355/.github/workflows/build-binaries.yml#L417-L419

Adding this should fix an observed segfault reported by a uv user: astral-sh/uv#15401

@woodruffw
uv: set JEMALLOC_SYS_WITH_LG_PAGE for ARM64 Linux builds
0c64f22 
Signed-off-by: William Woodruff <william@astral.sh>
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Aug 21, 2025
@woodruffw woodruffw mentioned this pull request Aug 21, 2025
Closed
carlocab
carlocab approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to set this more widely (e.g. in superenv): https://github.com/orgs/Homebrew/discussions/6353

@woodruffw
Copy link
Member Author

We may want to set this more widely (e.g. in superenv): github.com/orgs/Homebrew/discussions/6353

Yeah, I was thinking that probably makes sense! JEMALLOC_SYS_WITH_LG_PAGE only affects Rust builds that use jemalloc-sys, however -- I don't think there's a generic equivalent for all jemalloc builds. Still, maybe it makes sense in superenv?

@cho-m
Copy link
Member

cho-m commented Aug 21, 2025

Yeah, I was thinking that probably makes sense! JEMALLOC_SYS_WITH_LG_PAGE only affects Rust builds that use jemalloc-sys, however -- I don't think there's a generic equivalent for all jemalloc builds. Still, maybe it makes sense in superenv?

Superenv makes sense.

I didn't see a clean way for all jemalloc. Could set cache variable and hope it gets picked up, e.g. ENV["je_cv_lg_page"] = "16", but seems a bit odd.

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 21, 2025
@BrewTestBot BrewTestBot enabled auto-merge August 21, 2025 15:22
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 15a49e7 Aug 21, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the ww/uv-jemalloc branch August 21, 2025 15:31
woodruffw added a commit that referenced this pull request Aug 22, 2025
@woodruffw
fd: set JEMALLOC_SYS_WITH_LG_PAGE for ARM64 linux builds
e349b95 
See #234353 for prior art.

Signed-off-by: William Woodruff <william@astral.sh>
@woodruffw woodruffw mentioned this pull request Aug 22, 2025
Merged
6 tasks
@cho-m cho-m mentioned this pull request Sep 7, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. rust Rust use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@woodruffw @cho-m @carlocab @BrewTestBot