KEMBAR78
liquibase: deprecate due to license change in v5 by liquibot · Pull Request #246294 · Homebrew/homebrew-core · GitHub
Skip to content

Conversation

@liquibot
Copy link
Contributor

@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label Sep 30, 2025
@botantony
Copy link
Member

From the changelog (https://github.com/liquibase/liquibase/releases/tag/v5.0.0):

Additionally, Liquibase Community is now licensed under the Functional Source License (FSL). See LICENSE file at the root of the distribution for details. Starting with Liquibase 5.0, contributors will be asked to sign a one-time Contributor License Agreement (CLA). This is handled automatically by CLA Assistant when you open your first pull request.

I am not an expert in licenses and all the stuff but this does not sound like open-source to me. Need someone else to review this

@botantony botantony added the license License PRs label Sep 30, 2025
@fxcoudert
Copy link
Member

fxcoudert commented Sep 30, 2025

"Our policy is that formulae in the core tap (homebrew/core) must be open-source with a Debian Free Software Guidelines license" — from our documentation on Acceptable Formulae

The Functional Source License is not listed as open source. Therefore, liquibase should be migrated to a cask.

@chenrui333
Copy link
Member

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the update-liquibase.rb-1759240296 branch from 617afa5 to aeecdbd Compare September 30, 2025 17:15
@chenrui333 chenrui333 changed the title liquibase 5.0.0 liquibase: deprecate due to license change in v5 Sep 30, 2025
@github-actions github-actions bot added the formula deprecated Formula deprecated label Sep 30, 2025
@chenrui333
Copy link
Member

chenrui333 commented Sep 30, 2025

should be just deprecated due to the license change in v5.

The terms are not DSFG compatible as required by https://docs.brew.sh/License-Guidelines

@p-linnane p-linnane added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 30, 2025
@jandroav
Copy link

hey thanks for the review! Which alternatives do we have for both formulas?

Is this a valid approach?

  • Liquibase OSS

    • Versions <5.0.0: Stay in Homebrew Core (OSI-licensed) - brew install liquibase. This can not be updated anymore because of the license change

    • Versions ≥5.0.0: Move to Homebrew Cask (FSL-licensed) - brew install --cask liquibase (or maybe a different name)

  • Liquibase Secure

    • Brand new flavor, FSL-only from the start

    • Goes into Homebrew Cask as brew install --cask liquibase-secure

@p-linnane
Copy link
Member

@jandroav Based off this post you will probably want to create 2 casks. liquibase-community and liquibase-secure.

Assuming the 4.x branch is receiving no more updates, we will deprecate this formula.

@jnewton03
Copy link

hi @p-linnane ! We checked with product and the 4.x branch may receive security patches in the future. We are not closing it off entirely.

@p-linnane
Copy link
Member

@jnewton03 A few comments:

  • I'm looking for a concrete "v4 support ends on this date". "May receive security patches" is far too vague to not deprecate this
  • Are those patches going to be released under Apache-2.0?

@jnewton03
Copy link

@p-linnane , We are maintaining a branch of the 4.x lineage that will continue to release under Apache-2.0: https://github.com/liquibase/liquibase/tree/liquibase-4_33_x

I've reached out to product to get a support end date for 4.x. Stand by on that. Thanks!

@p-linnane
Copy link
Member

I've opened #246341 to restrict this formula to the 4.x branch, so it won't be deprecated.

@p-linnane p-linnane closed this Sep 30, 2025
@fxcoudert
Copy link
Member

@p-linnane I still think we should keep that open to have a deprecate with an end-of-support date in the formula

@p-linnane
Copy link
Member

I will open a fresh PR once @jnewton03 responds.

@jandroav
Copy link

jandroav commented Oct 8, 2025

Hey team, we opened this PR Homebrew/homebrew-cask#231392 and we see CI issues regarding the fact that liquibase already exists as a current formula, which is expected. Do we need to 100% rename the new liquibase cask to something else as proposed by @p-linnane here?

@p-linnane
Copy link
Member

@jandroav Yes, you should name that cask liquibase-community, since that's what the product name is.

@jandroav
Copy link

jandroav commented Oct 8, 2025

@jandroav Yes, you should name that cask liquibase-community, since that's what the product name is.

Thanks. We changed it and added a fix for the liquibase-secure livecheck and all seems to be good: https://github.com/Homebrew/homebrew-cask/actions/runs/18351642803?pr=231392

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated java Java use is a significant feature of the PR or issue license License PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants