-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
liquibase: deprecate due to license change in v5 #246294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
From the changelog (https://github.com/liquibase/liquibase/releases/tag/v5.0.0):
I am not an expert in licenses and all the stuff but this does not sound like open-source to me. Need someone else to review this |
|
"Our policy is that formulae in the core tap (homebrew/core) must be open-source with a Debian Free Software Guidelines license" — from our documentation on Acceptable Formulae The Functional Source License is not listed as open source. Therefore, liquibase should be migrated to a cask. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
617afa5 to
aeecdbd
Compare
|
should be just deprecated due to the license change in v5. The terms are not DSFG compatible as required by https://docs.brew.sh/License-Guidelines |
|
hey thanks for the review! Which alternatives do we have for both formulas? Is this a valid approach?
|
|
hi @p-linnane ! We checked with product and the 4.x branch may receive security patches in the future. We are not closing it off entirely. |
|
@jnewton03 A few comments:
|
|
@p-linnane , We are maintaining a branch of the 4.x lineage that will continue to release under Apache-2.0: https://github.com/liquibase/liquibase/tree/liquibase-4_33_x I've reached out to product to get a support end date for 4.x. Stand by on that. Thanks! |
|
I've opened #246341 to restrict this formula to the 4.x branch, so it won't be deprecated. |
|
@p-linnane I still think we should keep that open to have a deprecate with an end-of-support date in the formula |
|
I will open a fresh PR once @jnewton03 responds. |
|
Hey team, we opened this PR Homebrew/homebrew-cask#231392 and we see CI issues regarding the fact that |
|
@jandroav Yes, you should name that cask |
Thanks. We changed it and added a fix for the Thanks! |
Created by https://github.com/mislav/bump-homebrew-formula-action