KEMBAR78
qt 6.9.3 by cho-m · Pull Request #246844 · Homebrew/homebrew-core · GitHub
Skip to content

qt 6.9.3 #246844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2025
Merged

qt 6.9.3 #246844

merged 3 commits into from
Oct 7, 2025

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 4, 2025 •
edited
Loading

May be easier to review by viewing file by itself. The test is kept mostly the same (removing vulkan-loader dependency as not used) and bottle block is left, but everything else is changed which results in a difficult-to-read diff.

The idea here is to allow easy migration by making qt into something like a meta-package while providing symlinks that hopefully allow existing usage to still work.

Also use qt as a verification whenever Qt introduces new submodules.

brew deps --tree on Linux is slow. Locally not as bad as CI but can take a while as over 8GB of data is output. Trying to reduce this in worst case:

Improvement to Linux performance in:

@cho-m cho-m added staging-branch-pr This pull request targets a *-staging branch. blocked labels Oct 4, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Oct 4, 2025
@cho-m cho-m added the in progress Stale bot should stay away label Oct 4, 2025
@cho-m cho-m mentioned this pull request Oct 4, 2025
Merged
38 tasks
@cho-m cho-m changed the title qt 6.9.3 (WIP) qt 6.9.3 Oct 5, 2025
@cho-m cho-m added long dependent tests Set a long timeout for dependent testing and removed automerge-skip `brew pr-automerge` will skip this pull request blocked CI-linux-self-hosted Build on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing long build Set a long timeout for formula testing labels Oct 5, 2025
@cho-m cho-m marked this pull request as ready for review October 5, 2025 02:56
@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Oct 5, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Oct 5, 2025
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner labels Oct 5, 2025
@cho-m cho-m mentioned this pull request Oct 5, 2025
Merged
7 tasks
@cho-m cho-m added brew Issue may be Homebrew/brew related and removed brew Issue may be Homebrew/brew related labels Oct 5, 2025
@cho-m
Copy link
Member Author

cho-m commented Oct 6, 2025

deps check now works in reasonable time:

Mon, 06 Oct 2025 13:24:49 GMT ==> brew deps --tree --prune --annotate --include-build --include-test qt
Mon, 06 Oct 2025 13:24:54 GMT ==> Determining dependencies...

But build bottle is oddly slow (ongoing for 40+ minutes):

Mon, 06 Oct 2025 13:41:37 GMT ==> brew install --verbose --formula --build-bottle qt

In comparison, Intel macOS took 2 minutes:

Sun, 05 Oct 2025 07:28:51 GMT ==> brew install --verbose --formula --build-bottle qt
Sun, 05 Oct 2025 07:31:04 GMT ==> brew livecheck --autobump --formula --json --full-name qt

I wonder if something else in brew is inefficiently getting dependency tree as it should be quick.

@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 6, 2025
@cho-m

This comment was marked as outdated.

Sign in to view
@cho-m cho-m added the brew Issue may be Homebrew/brew related label Oct 6, 2025
@cho-m
Copy link
Member Author

cho-m commented Oct 6, 2025 •
edited
Loading

There is a performance issue with Build#expand_deps (or underlying Dependency#expand) as merging is done later which means it duplicates a lot of work.

EDIT: run at least finished. Snipping timestamps of slower parts:

Mon, 06 Oct 2025 14:56:14 GMT ==> brew install --only-dependencies --verbose --formula --build-bottle qt
Mon, 06 Oct 2025 15:20:15 GMT ==> Starting tests for qt

Mon, 06 Oct 2025 15:20:19 GMT ==> brew install --verbose --formula --build-bottle qt
Mon, 06 Oct 2025 17:03:21 GMT ==> brew livecheck --autobump --formula --json --full-name qt

Mon, 06 Oct 2025 17:05:06 GMT ==> brew install --only-dependencies ./qt--6.9.3.x86_64_linux.bottle.tar.gz
Mon, 06 Oct 2025 17:38:28 GMT ==> brew install ./qt--6.9.3.x86_64_linux.bottle.tar.gz

@cho-m cho-m marked this pull request as draft October 6, 2025 18:42
@cho-m cho-m mentioned this pull request Oct 6, 2025
Merged
7 tasks
@cho-m cho-m added CI-no-bottle-cache Disable bottle cache and removed CI-linux-self-hosted Build on Linux self-hosted runner labels Oct 7, 2025
@cho-m cho-m marked this pull request as ready for review October 7, 2025 00:49
@cho-m
Copy link
Member Author

cho-m commented Oct 7, 2025

Will follow up on linkage failures after merging staging branch as they are likely to create merge conflicts.

Brew PR should fix Linux build performance. Can verify in follow up PR to just test that.

This PR can be reviewed/merged in advance to try to get Qt split done by tomorrow or so.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

⚠️ Bottle publish failed.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

:shipit: @cho-m has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 7, 2025
@BrewTestBot BrewTestBot merged commit 7882591 into qt-split-staging Oct 7, 2025
8 checks passed
@BrewTestBot BrewTestBot deleted the qt-6.9.3 branch October 7, 2025 03:21
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branchvincent branchvincent branchvincent approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

brew Issue may be Homebrew/brew related CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing staging-branch-pr This pull request targets a *-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cho-m @branchvincent @BrewTestBot