Enable Web support for demo-compose-app #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| koin-bom = "4.1.1" | ||
| koog = "0.4.1" | ||
| kotlin = "2.2.10" | ||
| kotlin = "2.2.20" |
There was a problem hiding this comment.
Kotlin 2.2.20 introduce common webMain source set for js/wasmJs targets.
KT-79489 Generate Stdlib API reference for webMain source set
siarhei-luskanau
changed the title
siarhei-luskanau
force-pushed
the
example-compose-web
branch
from
4c2a6eb to
73bf0c2
Compare
siarhei-luskanau
force-pushed
the
example-compose-web
branch
from
73bf0c2 to
1606875
Compare
|
@kpavlov I have updated the PR:
Jvm, Android, iOS and Web (js/wasmJs) targets work as expected for me locally. |
|
Thank you @siarhei-luskanau |
kpavlov
reviewed
Sep 22, 2025
| implementation(libs.ktor.client.darwin) | ||
| } | ||
|
|
||
| webMain.dependencies { |
There was a problem hiding this comment.
Do we need any KTor client dependency specifically for web?
There was a problem hiding this comment.
Good question. Looks like default CIO Ktor engine is used for web. Actually it works without any Ktor dependency declarations for me .
aozherelyeva
approved these changes
Sep 22, 2025
This commit introduces WebAssembly (Wasm) and JS browser support to the demo-compose-app.
siarhei-luskanau
force-pushed
the
example-compose-web
branch
from
1606875 to
fb1baab
Compare
kpavlov
approved these changes
Sep 23, 2025
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Sep 25, 2025
This commit introduces WebAssembly (Wasm) and JS browser support to the demo-compose-app. <!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces WebAssembly (Wasm) and JS browser support to the demo-compose-app.
Motivation and Context
Breaking Changes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature