Add default audio configuration and modalities #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where audio-capable models were not properly handling text-only I/O operations. The fix ensures that when using audio-capable models without explicit audio configuration, default audio settings are provided while properly setting modalities.
- Decouples modalities configuration from audio configuration presence
- Adds default audio configuration for audio-capable models when no explicit audio config is provided
- Updates the request building logic to use the determined audio configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...penai-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/openai/OpenAILLMClient.kt
Show resolved
Hide resolved
Qodana for JVM871 new problems were found
@@ Code coverage @@
+ 68% total lines covered
11764 lines analyzed, 8006 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
aozherelyeva
approved these changes
Sep 22, 2025
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Sep 25, 2025
Fix [KG-298](https://youtrack.jetbrains.com/issue/KG-298) Throw error when passing audio models to text I/O ## Breaking Changes No --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [x] All new and existing tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KG-298 Throw error when passing audio models to text I/O
Breaking Changes
No
Type of the changes
Checklist
developas the base branch