[agents] Make AIAgentStorageKey in agent storage actually unique by removing data modifier
#825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing `data` modifier
Qodana for JVM912 new problems were found
@@ Code coverage @@
+ 68% total lines covered
12105 lines analyzed, 8241 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Sep 20, 2025
… removing `data` modifier (JetBrains#825) There's an issue in `AIAgentStorage` implementation where `AIAgentStorageKey` is incorrectly defined as a data class. This causes keys with identical names to be treated as equal due to auto-generated equals/hashCode methods, contradicting the documented behavior that each key instance should be unique regardless of name. The fix is straightforward - remove the data modifier from the class definition. This ensures storage keys are compared by instance identity rather than content equality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue in
AIAgentStorageimplementation whereAIAgentStorageKeyis incorrectly defined as a data class. This causes keys with identical names to be treated as equal due to auto-generated equals/hashCode methods, contradicting the documented behavior that each key instance should be unique regardless of name.The fix is straightforward - remove the data modifier from the class definition. This ensures storage keys are compared by instance identity rather than content equality.