KEMBAR78
KG-317: Do not include an empty system message in Anthropic request by antoniibelyshev · Pull Request #887 · JetBrains/koog · GitHub
Skip to content

Conversation

antoniibelyshev
Copy link
Collaborator

@antoniibelyshev antoniibelyshev commented Sep 30, 2025

Motivation and Context

KG-317 Do not require a system prompt

Breaking Changes


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@github-actions
Copy link

Qodana for JVM

844 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 825
Vulnerable imported dependency 🔶 Warning 17
Unused import directive 🔶 Warning 1
Missing KDoc for public API declaration 🔶 Warning 1
@@ Code coverage @@
+ 70% total lines covered
12418 lines analyzed, 8709 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@aozherelyeva aozherelyeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@antoniibelyshev antoniibelyshev merged commit af7cd9f into develop Sep 30, 2025
11 checks passed
@antoniibelyshev antoniibelyshev deleted the belyshev/fix-antropic-fails-without-system-message branch September 30, 2025 11:53
karloti pushed a commit to karloti/koog that referenced this pull request Oct 21, 2025
…etBrains#887)

<!--
Thank you for opening a pull request!

Please add a brief description of the proposed change here.
Also, please tick the appropriate points in the checklist below.
-->

## Motivation and Context
<!-- Why is this change needed? What problem does it solve? -->

[KG-317](https://youtrack.jetbrains.com/issue/KG-317) Do not require a
system prompt

## Breaking Changes
<!-- Will users need to update their code or configurations? -->

---

#### Type of the changes
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Tests improvement
- [ ] Refactoring

#### Checklist
- [x] The pull request has a description of the proposed change
- [x] I read the [Contributing
Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md)
before opening the pull request
- [x] The pull request uses **`develop`** as the base branch
- [ ] Tests for the changes have been added
- [x] All new and existing tests passed

##### Additional steps for pull requests adding a new feature
- [x] An issue describing the proposed change exists
- [x] The pull request includes a link to the issue
- [ ] The change was discussed and approved in the issue
- [ ] Docs have been added / updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants