feat: Use dynamic import for external JS #26522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
2 times, most recently
from
22e99d2 to
54083d7
Compare
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
2 times, most recently
from
73a09f0 to
250649f
Compare
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
5 times, most recently
from
849dcb7 to
373d1a5
Compare
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
from
373d1a5 to
f4775f5
Compare
Nerivec
added a commit
to Nerivec/zigbee2mqtt.io
that referenced
this pull request
Mar 15, 2025
Nerivec
added a commit
to Nerivec/zigbee-herdsman-converters
that referenced
this pull request
Mar 15, 2025
Nerivec
added a commit
to Nerivec/zigbee-herdsman-converters
that referenced
this pull request
Mar 16, 2025
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
2 times, most recently
from
4fdb7a9 to
cd7043d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
from
c6bdd1c to
a2783a9
Compare
|
Koenkk I'll let you give it a run or two before merging, just to be sure I haven't missed something! |
Nerivec
force-pushed
the
externaljs-dynamic-import
branch
from
a2783a9 to
b4883a3
Compare
Koenkk
pushed a commit
to Koenkk/zigbee-herdsman-converters
that referenced
this pull request
Mar 20, 2025
Koenkk
pushed a commit
to Koenkk/zigbee2mqtt.io
that referenced
this pull request
Mar 20, 2025
|
Works, another step forward, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node:vmlogic with dynamic importing.js,.cjsand.mjscodesavewhen file already exists (also allows to bypass node module caching)TODO: