Make kwargs optional to the eval output customizer scripts #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
AnuradhaKaruppiah
added
feature request
There was a problem hiding this comment.
Pull Request Overview
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include:
- Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs.
- Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths.
- Revising the documentation to reflect the new usage and relative paths.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aiq/data_models/evaluate.py | Default kwargs added, making keyword arguments optional for custom scripts |
| examples/simple/src/aiq_simple/scripts/workflow_to_csv.py | Updated default input/output paths in argument parser |
| docs/source/concepts/evaluate.md | Documentation updated to match new configuration and clarify path usage |
yczhang-nv
approved these changes
Apr 21, 2025
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 23, 2025
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include: Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs. Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths. Revising the documentation to reflect the new usage and relative paths. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#139 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 23, 2025
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include: Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs. Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths. Revising the documentation to reflect the new usage and relative paths. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#139 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include: Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs. Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths. Revising the documentation to reflect the new usage and relative paths. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#139 Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah
added a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include: Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs. Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths. Revising the documentation to reflect the new usage and relative paths. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#139
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include: Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs. Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths. Revising the documentation to reflect the new usage and relative paths. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes the keyword arguments for the evaluation output customizer scripts optional, allowing users to omit them. Key changes include:
Updating EvalCustomScriptConfig in evaluate.py to set a default empty dictionary for kwargs.
Changing the workflow_to_csv.py script’s argument parser to use default values for input and output paths.
Revising the documentation to reflect the new usage and relative paths.
By Submitting this PR I confirm: